Skip to content

Commit

Permalink
Fix for #138
Browse files Browse the repository at this point in the history
  • Loading branch information
VioletGiraffe committed Jun 2, 2015
1 parent 6b9a344 commit ea95cc2
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 4 deletions.
21 changes: 18 additions & 3 deletions CPPCheckPlugin/CPPCheckPlugin.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="4.0">
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="12.0">
<PropertyGroup>
<MinimumVisualStudioVersion>11.0</MinimumVisualStudioVersion>
<MinimumVisualStudioVersion>12.0</MinimumVisualStudioVersion>

This comment has been minimized.

Copy link
@Dmitry-Me

Dmitry-Me Jun 3, 2015

Collaborator

Why was minimum version changed?

This comment has been minimized.

Copy link
@VioletGiraffe

VioletGiraffe Jun 3, 2015

Author Owner

@Dmitry-Me : Because my VS 2013 makes that change every time I open the project, and this time I didn't notice it.

This comment has been minimized.

Copy link
@Dmitry-Me

Dmitry-Me Jun 16, 2015

Collaborator

@VioletGiraffe May I undo this part of the change?

This comment has been minimized.

Copy link
@VioletGiraffe

VioletGiraffe Jun 16, 2015

Author Owner

Absolutely!

This comment has been minimized.

Copy link
@ariccio

ariccio Jun 18, 2015

Do you have VS2013 update 4?

This comment has been minimized.

Copy link
@VioletGiraffe

VioletGiraffe Jun 18, 2015

Author Owner

Don't remember the number, but it's the current latest VS 2013 update. Either 4 or 5.

<VisualStudioVersion Condition="'$(VisualStudioVersion)' == ''">11.0</VisualStudioVersion>
<VSToolsPath Condition="'$(VSToolsPath)' == ''">$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)</VSToolsPath>
<FileUpgradeFlags>
Expand Down Expand Up @@ -47,6 +47,9 @@
<Reference Include="Microsoft.CSharp" />
<Reference Include="Microsoft.VisualStudio.OLE.Interop" />
<Reference Include="Microsoft.VisualStudio.Shell.Interop" />
<Reference Include="Microsoft.VisualStudio.Shell.Interop.12.0, Version=12.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<EmbedInteropTypes>True</EmbedInteropTypes>
</Reference>
<Reference Include="Microsoft.VisualStudio.Shell.Interop.8.0" />
<Reference Include="Microsoft.VisualStudio.Shell.Interop.9.0" />
<Reference Include="Microsoft.VisualStudio.Shell.Interop.10.0" />
Expand Down Expand Up @@ -140,7 +143,9 @@
</EmbeddedResource>
</ItemGroup>
<ItemGroup>
<None Include="app.config" />
<None Include="app.config">
<SubType>Designer</SubType>
</None>
<None Include="Properties\Settings.settings">
<Generator>SettingsSingleFileGenerator</Generator>
<LastGenOutput>Settings.Designer.cs</LastGenOutput>
Expand Down Expand Up @@ -172,24 +177,34 @@
<Page Include="CppcheckMessagesList.xaml">
<SubType>Designer</SubType>
<Generator>MSBuild:Compile</Generator>
<Generator>MSBuild:Compile</Generator>
<SubType>Designer</SubType>
</Page>
<Page Include="CppcheckSettings.xaml">
<SubType>Designer</SubType>
<Generator>MSBuild:Compile</Generator>
<Generator>MSBuild:Compile</Generator>
<SubType>Designer</SubType>
<Generator>MSBuild:Compile</Generator>
<SubType>Designer</SubType>
</Page>
<Page Include="MainToolWindowUI.xaml">
<SubType>Designer</SubType>
<Generator>MSBuild:Compile</Generator>
<Generator>MSBuild:Compile</Generator>
<SubType>Designer</SubType>
</Page>
<Page Include="SuppressionsSettingsUI\ItemsListEditor.xaml">
<SubType>Designer</SubType>
<Generator>MSBuild:Compile</Generator>
<Generator>MSBuild:Compile</Generator>
<SubType>Designer</SubType>
</Page>
<Page Include="SuppressionsSettingsUI\SuppressionsSettings.xaml">
<SubType>Designer</SubType>
<Generator>MSBuild:Compile</Generator>
<Generator>MSBuild:Compile</Generator>
<SubType>Designer</SubType>
</Page>
</ItemGroup>
<PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion CPPCheckPlugin/source.extension.vsixmanifest
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
<Metadata>
<Identity Id="127d8bd3-8cd7-491a-9a63-9b4e89118da9" Version="1.2.1" Language="en-US" Publisher="-" />
<Identity Id="127d8bd3-8cd7-491a-9a63-9b4e89118da9" Version="1.3.1" Language="en-US" Publisher="-" />
<DisplayName>cppcheck add-in</DisplayName>
<Description xml:space="preserve">Integration for cppcheck - C/C++ code static analysis tool </Description>
<License>PackageInstallerLicense.txt</License>
Expand Down

0 comments on commit ea95cc2

Please sign in to comment.