Fixed deprecated relatedTableAlias from Objection.js #43
Conversation
|
Oups ! I forgot to upgrade Objection.js dependency. Running with the currently latest (1.5.3) seem Ok |
|
@marcpearson Thank you for your pull request! Could you please fix test failures? |
|
@kibertoad Excuse my english i'm a french speaker (Québec). Maybe i could help with that but i don't know how to set my computer to run your tests correctly. It seems i need to have postgreSQL and sqlite. The errors seems to be related to others problems not because of my modification. But if you explain me how to run tests i will take a look ... |
Objection.js renamed build function to toKnexQuery from version 1.6.3 Upgrade dependencies and devDependencies to fix vulnerabilities Upgrade minimal version of Objection to 1.6.3
|
@koskimas Does the original fix looks like a valid equivalent in modern Objection.js? |
- Fixed breaking changes for objection 2.0.3
|
@marcpearson Hey, do you have any issue with the current released version of objection-find? |
|
To be honest, I have not tried your version for a while. The pull-request that I submitted a few months ago has never been merged and the search for objections does not work as before. It may be time to try again. But I'm starting some new projects and I want to start with the Objection V2 branch. Until you support Objection V2, I will stay with my fork. After migrating to V2, I will try it and see if all my projects are successful in all my integration tests. I will be happy to stay with the original objection-find but the development seems to slow down considerably |
|
@marcpearson I already checked and tried your version, it works better. Can you please make a new PR with the fix commit and a migration to objection2 commit. That will help kibertoad to merge it. I am also waiting for this to start using objection2 |
|
@marcpearson Any chance you can rebase this? |
|
HI @kibertoad First, i'll be glad to help i very appreciate objection-find but because french is my native language i'm not sure to understand what i need to do. Secondly, i'm not an expert with Git/Github/Pull-request. So if you want to guide me i will do all the necessary things. But before we go with further processing, some questions
|
|
@marcpearson
To answer your questions
|
|
After rebasing my code with the latest commit from objection-find original repo i see that the bug #48 it still present. Searching with a field from HasOneRelation is broken. The fullColumName code is not working as before ... So i dont know what to do with this... my fork has already the fixed I also see that the version in package-find.json is 2.0.0 but reported 1.6.5 in package-lock.json. My package-lock.json is updated after "npm install" but will this create a conflict My fork is already patched to use objection V2+. I can merge all the upstream changes im my fork and make some fixes but I'm not sure how to make the pull-request for all this minors problems ? |
|
After digging more thorouglhy in the code, the bug #48 is probably related to the fact that the tablename in all my objection model definition use the pattern «database.tablename» to be able to do joined queries againts different database in MySQL. The current _buildJoins method in FindQueryBuilder doesn't support tablename with a database part so i overload this method in an other part of my application (I forgot that !!!) |
|
@marcpearson I've applied fix to PropertyRef that you've done to master. However,
change throws an eror due to method not existing. Is this a custom method that you introduced in your own fork? |
|
Eager method was deprecated and replace with «withGraphFetched» in objection version 2+. So be sure to use objection.js version 2+. Check in your node_modules if you have objection.js 2 installed. If not, refresh your node_modules installed version. Something like rm -rf node_modules and npm install |
|
@marcpearson Could you please resolve the conflicts? Then this could be merged. |
|
It's no more necessary :) |
|
@marcpearson I don't think we ever fixed this part :(. Why wouldn't this fix be useful anymore? |
Hi
I made a modification to fix the error about relatedTableAlias. This function didn't exists anymore in objection.js.
Maybe you have a better way to fix this error !