Skip to content

Commit

Permalink
Update Danger JS to v11 (facebook#33027)
Browse files Browse the repository at this point in the history
Summary:
Danger 7 -> 11

## Changelog

[Internal] [Changed] - Updates Danger used in PR checking from v7 to v11

Pull Request resolved: facebook#33027

Test Plan:
Works when testing locally

```
> DANGER_GITHUB_API_TOKEN=XXYYZZ yarn danger pr facebook#32955
yarn run v1.22.15
$ node ./node_modules/.bin/danger pr facebook#32955
Starting Danger PR on facebook#32955
 --- Accurate Error due to not being able to write to labels ---

## Failures
`node` failed.
## Messages
:clipboard: Missing Summary - <i>Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.</i>
-
:clipboard: Missing Test Plan - <i>Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.</i>
-
:clipboard: Missing Changelog - <i>Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: `[CATEGORY] [TYPE] - Message`.

<details>CATEGORY may be:

- General
- iOS
- Android
- JavaScript
- Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

- Added, for new features.
- Changed, for changes in existing functionality.
- Deprecated, for soon-to-be removed features.
- Removed, for now removed features.
- Fixed, for any bug fixes.
- Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level.   Use this to briefly tell React Native users about notable changes.</details></i>
## Markdowns

Danger: ⅹ Failing the build, there is 1 fail.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

```

Reviewed By: GijsWeterings

Differential Revision: D33941271

Pulled By: cortinico

fbshipit-source-id: 359c0076a160a8eeac897a2e1556d3e4d3db5e04
  • Loading branch information
orta authored and facebook-github-bot committed Feb 2, 2022
1 parent f185d42 commit fbb9d33
Show file tree
Hide file tree
Showing 2 changed files with 388 additions and 1,222 deletions.
2 changes: 1 addition & 1 deletion bots/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"danger": "node ./node_modules/.bin/danger"
},
"devDependencies": {
"danger": "^7.1.4",
"danger": "^11.0.2",
"lodash.includes": "^4.3.0",
"minimatch": "^3.0.4"
},
Expand Down
Loading

0 comments on commit fbb9d33

Please sign in to comment.