Skip to content

Commit

Permalink
Fix incorrect merged asset path with flavor for Android Gradle Plugin…
Browse files Browse the repository at this point in the history
… 3.2. (facebook#21782)

Summary:
When we use product flavor (e.g. develop/production) with Android Gradle Plugin 3.2,
javascript bundle is not copied due to that merged asset path point to incorrect location.

related facebook#21408

<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.

If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.

_Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_
-->
Pull Request resolved: facebook#21782

Differential Revision: D12854056

Pulled By: hramos

fbshipit-source-id: d1e6a395e762cc4a4f133977d54d0f469fa66b8c
  • Loading branch information
yatatsu authored and facebook-github-bot committed Oct 31, 2018
1 parent a689711 commit e90319e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion react.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ afterEvaluate {
}

// Workaround for Android Gradle Plugin 3.2+ new asset directory
into ("merged_assets/${targetPath}/merge${targetName}Assets/out") {
into ("merged_assets/${variant.name}/merge${targetName}Assets/out") {
from jsBundleDir
}
}
Expand Down

0 comments on commit e90319e

Please sign in to comment.