Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bash #26

Merged
merged 2 commits into from
Mar 25, 2017
Merged

Remove bash #26

merged 2 commits into from
Mar 25, 2017

Conversation

blueyed
Copy link
Member

@blueyed blueyed commented Mar 25, 2017

This requires to install ncurses explicitly, which was installed as a
dep for bash before, and Vim requires it.

Ref: #20 (comment)

This requires to install ncurses explicitly, which was installed as a
dep for bash before, and Vim requires it.

Ref: Vimjas#20 (comment)
Copy link
Collaborator

@tweekmonster tweekmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me if you know it runs. I tend to use bash because it's my safe medium for scripts 😬

@blueyed
Copy link
Member Author

blueyed commented Mar 25, 2017

if you know it runs

We have quite good tests for vim-testbed already after all.
And if it breaks for users, they should add apk --no-cache add bash to their Dockerfile.

@blueyed blueyed merged commit e8fb50c into Vimjas:master Mar 25, 2017
@blueyed blueyed deleted the remove-bash branch March 25, 2017 21:47
@blueyed
Copy link
Member Author

blueyed commented Mar 25, 2017

Thanks @bounceme for pointing it out in #20 (comment)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants