Publish BACKUPMON v1.8.17 #50
Conversation
New code that enables checking multiple website URLs to download the Custom Email Library Script, just in case the first URL is not available for any reason.
Code improvements.
Fine-tuning.
Code improvements & fine-tuning.
More code improvements & fine-tuning.
Fine-tuning.
Check multiple URLs to download Custom Email Library
Added new "-veryquiet" parameter that can be used when checking for & downloading updates for the custom email library script.
Added "-veryquiet" parameter to email library.
| cemailQuietArg="-verbose" | ||
| cemailCheckArg="-versionCheck" | ||
| fi | ||
| _CheckForCustomEmailLibraryScript_ "$cemailCheckArg" "$cemailQuietArg" |
There was a problem hiding this comment.
WRT lines 1160 to 1167:
Is there any specific reason for having the setup & call to the "_CheckForCustomEmailLibraryScript_ " function before sending a test email? IOW, what was the goal for placing the additional call here?
It should not be necessary at all, and it's rather redundant since it was already done at the start of script execution.
There was a problem hiding this comment.
It was actually my original intention for this section to be the piece that originally downloads the library, so that we don't take up space on people's routers that don't have amtm email enabled. But I need to refine this piece a bit more.
|
Just to clarify, the primary goal of placing the call to check for updates to the custom email library at the start of the script is to minimize the number of calls. In previous versions of backupmon, you had placed the code to the library in multiple places which was unnecessary and inefficient. My latest changes are a way to rectify that. |
|
For the piece at the beginning, I actually forgot to qualify running this with an "if [ $AMTMEMAIL -eq 1 ]", in order to kick this off, again to weed out needing to download if this feature is turned off. But once it's yes, this would be the only place it gets updated. The piece under the config is primarily for initial install, using the verbose mode to give visual feedback. |
Ah, OK, I understand now. The " Your latest update version "1.8.18" includes the above changes so it's all set up nicely now. Excellent!! |
|
BTW, there are still some references to "Backup Frequency" that should be changed to "Backup Retention" for consistency throughout the UI menus. Just FYI.
|
|
Dangit! Thanks for the catch. 😋 |
|
@Martinski4GitHub ... it seems "if [ -z "${amtmIsEMailConfigFileEnabled:+xSETx}" ]" is coming back as null, causing a condition that the Email Library Script is not being found. Any ideas? I put some screenshots/examples on SNB as well...
|
< The fix is to predicate the "test email" option on "email notifications" being previously enabled by the user; otherwise, the test cannot be performed. |
|
But for me it is 1, or enabled, so it should have loaded the library? By running the check update at the beginning of the script, it should load the library right? |
If the variable AMTMEMAIL is set to 1 by the time the code to check for the email library is executed, then yes it will be loaded into memory. The problem with the "email test" section is that the variable is not even checked, so email notifications may or may not have been enabled yet. |
|
I just ran a simple test by typing " This indicates that the variable AMTMEMAIL is likely not yet set correctly based on the current configuration settings. |
|
I think that was it... Your code is probably executing before I'm calling my config file variables. Thank you Martinski! |
No description provided.