[UPG][17.0] viin_brand_payment_paypal, viin_brand_payment_authorize: upgrade to v17.0 #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viinbot
added
🚀 Queue
trungtuan88
force-pushed
the
v17_upg_viin_brand_payment_paypal
branch
from
8882b0b
to
8196ebe
Compare
viinbot
added
🚀 Queue
trungtuan88
changed the title
viinbot
added
🚀 Building
|
@trungtuan88 Viindoo Test Suite has failed! |
trungtuan88
force-pushed
the
v17_upg_viin_brand_payment_paypal
branch
from
8196ebe
to
c5f1859
Compare
viinbot
added
🚀 Queue
trungtuan88
force-pushed
the
v17_upg_viin_brand_payment_paypal
branch
from
c5f1859
to
8d9d4fd
Compare
viinbot
added
🚀 Queue
trungtuan88
commented
Jul 12, 2024
Comment on lines
7
to
11
| <xpath expr="//group[@name='provider_credentials']/group/a" position='attributes'> | ||
| <xpath expr="//group[@name='provider_credentials']/group/a[@href='https://www.odoo.com/documentation/17.0/applications/finance/payment_providers/authorize.html']" | ||
| position='attributes'> | ||
| <!-- Todo: Wait for the consulting department to add the link --> | ||
| <attribute name="href">https://viindoo.com/documentation/16.0/applications/finance/accounting-and-invoicing/account-receivables/customer-payments/how-to-make-a-payment-with-authorize-net.html</attribute> | ||
| </xpath> | ||
| <attribute name="style">display: none;</attribute> |
There was a problem hiding this comment.
- Hiện tại link này nhà mình đã xóa đi vì chưa có bài viết. vì vậy a tạm thời ẩn link đi.
- Đường dẫn xpath kia cần tìm đến link cụ thể bởi vì nều để code gốc nếu mà cài 2 phương thức thanh toán lên thì phương thức nào cài sau sẽ ko xpath được
There was a problem hiding this comment.
@trungtuan88 anh xem lại chỗ này: chưa có thì thôi không xpath nữa, có bài từ 16 rồi thì để 16 và không ẩn nó, vì sau này thay sang bài 17 thì dùng tools thay, sẽ không biết là phải xóa cái dòng <attribute name="style">display: none;</attribute>
viinbot
added
🚀 Building
|
@trungtuan88 Viindoo Test Suite has failed! |
| @@ -4,9 +4,12 @@ | |||
| <field name="model">payment.provider</field> | |||
| <field name="inherit_id" ref="payment_authorize.payment_provider_form"/> | |||
| <field name="arch" type="xml"> | |||
| <xpath expr="//group[@name='provider_credentials']/group/a" position='attributes'> | |||
| <xpath expr="//group[@name='provider_credentials']/group/a[@href='https://www.odoo.com/documentation/17.0/applications/finance/payment_providers/authorize.html']" | |||
There was a problem hiding this comment.
@trungtuan88 anh làm theo cách này nhé, tránh khớp tuyệt đối link, vì Odoo đổi link thì sẽ lỗi
Suggested change
| <xpath expr="//group[@name='provider_credentials']/group/a[@href='https://www.odoo.com/documentation/17.0/applications/finance/payment_providers/authorize.html']" | |
| <xpath expr="//group[@name='provider_credentials']/group[@invisible='code != 'authorize'']/a" |
There was a problem hiding this comment.
@trungtuan88 tương tự với module paypal
trungtuan88
force-pushed
the
v17_upg_viin_brand_payment_paypal
branch
from
8d9d4fd
to
420b56d
Compare
viinbot
added
🚀 Queue
viinbot
added
🚀 Building
|
@trungtuan88 Viindoo Test Suite has failed! |
trungtuan88
force-pushed
the
v17_upg_viin_brand_payment_paypal
branch
from
420b56d
to
5497b91
Compare
viinbot
added
🚀 Queue
|
@trungtuan88 Viindoo Test Suite has passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: viin_brand_payment_paypal
Task: viin_brand_payment_authorize
simplescreenrecorder-2024-07-12_14.07.33.mp4