Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one opens a REPL and then Restarts a REPL, one gets errors about wrong buffer ids.
The reason is that core.repl_restart deletes the old buffer. But the default of close_window_on_exit, will try to delete it too.
Also if one calls IronRestart from a code buffer, changes are done to meta, but new_meta is returned.
I made a commit that fixes this, by not altering meta, but altering new_meta.
Also it will be checked in the on exit option, whether the buffer still exist.
I will create a merge request.
I also observed that many functions will differ strongly whether the cursor is on code buffer or repl buffer. One could change that if the get_ft would check on empty file type, if the buffer is the buffer of a repl and then use the ft from store.
I checked that, but I am unsure whether this could have some side effects.
See #387 (comment)