operator: moved CRD to subchart #1560
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
requested review from
zekker6,
Haleygo and
f41gh7
as code owners
github-actions
bot
added
k8s-stack
zekker6
reviewed
Oct 7, 2024
Comment on lines
-31
to
+35
| crd: | ||
| # -- Enables CRD creation and management. With this option, if you remove this chart, all CRD resources will be deleted with it. | ||
| create: true | ||
| crds: | ||
| # -- check if plain or templated CRDs should be created. | ||
| # with this option set to `false`, all CRDs will be rendered from templates. | ||
| # with this option set to `true`, all CRDs are immutable and require manual upgrade. | ||
| plain: false |
There was a problem hiding this comment.
It seems like this change makes it impossible to disabled CRDs deployment completely. Is that expected?
There was a problem hiding this comment.
yes, next step is CRD management removal from k8s-stack
single place, with CRDs instead of having them both in operator and k8s stack managed differently (as templates in operator and as plain CRDs in k8s-stack) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crd.enabledtocrds.plain, which instead of disabling CRDs templating, changes a mode in which CRDs should be rendered: as plain text CRDs or as templates