Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s-stack: generate vm components tag from app version by default #1553

Merged
merged 3 commits into from
Oct 4, 2024
Merged

k8s-stack: generate vm components tag from app version by default #1553

merged 3 commits into from
Oct 4, 2024

Conversation

AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Oct 3, 2024 •
edited
Loading

@github-actions github-actions bot added the k8s-stack k8s-stack helm chart related issue label Oct 3, 2024
zekker6
zekker6 previously approved these changes Oct 3, 2024
View reviewed changes
@github-actions github-actions bot added the cluster vmcluster helm chart related issue label Oct 4, 2024
Haleygo
Haleygo approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@Haleygo Haleygo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewChubatiuk AndrewChubatiuk merged commit bc8f462 into master Oct 4, 2024
11 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the tag-name-from-app-version branch October 4, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haleygo Haleygo Haleygo approved these changes

@f41gh7 f41gh7 Awaiting requested review from f41gh7 f41gh7 is a code owner

@zekker6 zekker6 Awaiting requested review from zekker6 zekker6 is a code owner

Assignees
No one assigned
Labels
cluster vmcluster helm chart related issue k8s-stack k8s-stack helm chart related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cluster] .Values.rbac is not used
3 participants
@AndrewChubatiuk @zekker6 @Haleygo