Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #4 Ready For Review #16

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Issue #4 Ready For Review #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2b06de5
Fixed issue with sections not wrapping at tablet screen size
May 2, 2023
34a8e15
Revert "Removed email const from lib.js in issue-3 because no longer …
May 2, 2023
a842f79
Merge branch 'main' into rob-dev
May 2, 2023
73e4089
Reduced the max-height of the image so the full page can appear on my…
May 2, 2023
b1f3bf8
Added and alert to test if Netlify live update is working
May 2, 2023
d6bbc63
Test complete. Netlify is connected to repository. Removed test alert…
May 2, 2023
c8d8654
Merge branch 'main' into rob-dev
May 2, 2023
250527f
Fixed issue with tablet sizing
May 22, 2023
a7ef1b4
Fixed issue with mobile: Image was rendering at 80% instead of 100%
May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions issue-3/lib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
const email = '[email protected]';


let setFirstSection = () => {
const header = document.querySelector('header');
const body = document.querySelector('.first');
Expand Down
1 change: 1 addition & 0 deletions issue-4/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Issue #4</title>
<link rel="stylesheet" href="./styles.css">
</head>
Expand Down
25 changes: 23 additions & 2 deletions issue-4/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ body {

img {
width: 80%;
max-height: 75vh;
margin: 0 10% 20px 10%;
animation: zoomInFadeIn 1s ease-in-out;
}
Expand All @@ -42,15 +43,19 @@ img {
}

.bottom__button {
height: 80px;
width: 80px;
margin: 0 calc(16vw - 25px) 0 calc(16vw - 25px);
padding: 10px 20px 10px 20px;
box-shadow: 2.5px 2.5px 8px 2.5px rgb(89, 80, 80);
background-color: green;
border-radius: 5px;
transition: border-radius .2s ease-in;
}

.bottom__button:hover {
cursor: pointer;
border-radius: 20%;
}

.bottom__button:active {
Expand All @@ -70,7 +75,7 @@ img {
background-color: blue;
}

@media screen and (max-width: 768px) {
@media screen and (max-width: 1024px) and (min-width: 768px) {
.top__section {
width: calc(50% - 10px);
}
Expand All @@ -81,10 +86,26 @@ img {
}
}

@media screen and (max-width: 480px) {
@media screen and (max-width: 767px) {
.top__section {
width: 100%;
}

img {
width: 100%;
margin: 0 0 20px 0;
}

.bottom {
display: flex;
flex-direction: column;
align-items: center;
}

.bottom__button {
margin-bottom: 20px;
width: 60%;
}
}

@keyframes slideInTToB {
Expand Down