I have implemented the validation for the new users using firebase. #76
Conversation
|
@razputshivanshu is attempting to deploy a commit to the Akshay Patel's projects Team on Vercel. A member of the Team first needs to authorize it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The code is working fine but it always ask for verification while login that is not a good idea email verification should be done on registration at time of login you can add a captcha |
|
Could you explain it in a bit more detail or add some screenshots? That would be really helpful. Any suggestions on how I can improve it? |
|
The email verification works on login every time a user login If every time user has to verify for login it will be very hectic |
|
I understood. I will try to fix this in next 1-2 days. |
|
Okay |
|
It seems like the issue might be related to logging in with an account created before the verification feature was implemented, which could be why the verification prompt appears. On my end, I can log in without needing verification. Here’s what I suggest to troubleshoot further: Test 1: Try creating a new account, validate it, and then log in to see if the same issue persists. If it does, let me know, and I’ll look into it further. If the application hasn’t been launched for real users yet, consider resetting the database to start fresh. This will clear all user data, allowing the process to function smoothly. Alternatively, you could write a JS query to trigger validation emails for existing users. Here’s the link I used for testing on my end: |
|
Okay I will into this and try to resolve this issue |
|
One more thing in your code while registering the registration form does not have register with google option |
Ooky I missed that by mistake, I will fix that. |
|
Okay |
|
and if the user is old then the prompt comes for verification but for old accounts they don't email for verification |
I have updated that, you can check |
|
Remove your api from the env file |
yes, that's the catch because many users has already login before the validation. Wait I will look for something so that user's who already have account can validate their emails. |
ooh sorry my bad |
|
Sir, I have fixed validation for old users issue. Can you check it once? |
VesperAkshay
added
hacktoberfest
|
All the changes are good |
Description
Implemented validation for new users to prevent unauthorized access to the website. This update enhances security by ensuring that only authorized users can proceed to access restricted parts of the application.
Related Issue
Link to the issue this PR addresses (if applicable):
Type of Change
Checklist
Additional Notes
Any other information that reviewers should know about this PR.
Make sure before running this code, enable these settings from Firebase console:
Authentication > Sign In method > Enable Email/Password & Email link (passwordless sign-in)
I have tested this code from my end, and the video is here:
The video size was big, so I am linking the google drive link:
https://drive.google.com/file/d/1eq1Y7-4DFETrgCslIIlzIP6eoD_YvLQg/view?usp=sharing
If you have any questions or need clarification, please feel free to ask in the issue comments. I’ll be available for an open discussion.
I hope you enjoyed my first contribution to the open-source project. If you liked my work, I would greatly appreciate it if you could tag this issue as level 3. It would be very helpful for me.