Java script week3 #1
Conversation
| ]; | ||
| const index = Math.floor(Math.random() * 10); | ||
| const compliment = compliments[index]; | ||
| return `You are ${compliment}, ${name}!`; |
There was a problem hiding this comment.
Very nicely done and good use of variables.
| // TODO complete this function | ||
| age = age * 7; |
There was a problem hiding this comment.
I think you can remove the TODO comments once you have implemented the logic. Also, in this case, I would recommend to create a new variable here(if needed) instead of mutating the function argument. It would be much cleaner. For example,
function calculateDogAge(age) {
const dogAge = age * 7;
return `Your doggie is ${dogAge} years old in dog years!`;
}
or
function calculateDogAge(age) {
return `Your doggie is ${age * 7} years old in dog years!`;
}
| const location = selectRandomly(address); | ||
| const partnerName = selectRandomly(name); | ||
|
|
||
| return `You will be a ${jobTitle} in ${location}, married to ${partnerName} with ${numKids} kids.`; |
| shoppingCart.push(groceryItem); | ||
| } | ||
| const groceriesString = shoppingCart.join(', '); | ||
| return `You bought ${groceriesString}!`; |
| if (newArr.length < 3) { | ||
| newArr.push(groceryItem); | ||
| } else { | ||
| newArr.shift(); | ||
| newArr.push(groceryItem); | ||
| } |
There was a problem hiding this comment.
What if you did this instead? A bit cleaner, right?
const newArr = [...arr];
newArr.push(groceryItem);
if (newArr.length > 3) {
newArr.shift();
}
return newArr;
| }; | ||
|
|
||
| function calculateTotalPrice(/* TODO parameter(s) go here */) { | ||
| // TODO replace this comment with your code | ||
| function calculateTotalPrice(cart) { |
There was a problem hiding this comment.
Hi Veronica - although this logic works fine but you could improve it slightly. Firstly, you should try to avoid using for-in loops for iterating over objects. Try to use Object.keys() instead. The difference between the two can be found out on google, it's something to do regarding iterating over parent object properties. Secondly, if you use Object.keys, you could also look at using the array's reduce method. Something like below:
function calculateTotalPrice(cart) {
const total = Object.keys(cart).reduce((acc, elem) => acc + cart[elem], 0);
return `Total: ${total}`;
}
| for (const employee of arrEmployees) { | ||
| const { name, occupation, email } = employee; | ||
| const employeeNew = { name, occupation, email }; | ||
| newArrEmployees.push(employeeNew); |
|
Hello Yash! Thank you for your comments! I hope I fixed everything. |
No description provided.