64bit key support with bigints #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewaveryusa
changed the title
|
Sorry for the late reply. Will review this as soon as I can. |
|
No worries. This patch will need some reworking as it touches the same areas in the codebase as the async pull request #150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #111. I didn't implement defaulting bigints to buffers since there's no easy v8 api to transform a bigint into an array of bytes. I'm guessing v8 doesn't expose such an API to avoid making an opinionated choice on how to store signed numbers in binary format (the logical options being either twos compliment or signbit+unsignedbytes.)
With that in mind I think the correct approach is to allow users to choose how they want to serialize bigints. The obvious easy answer it to use the toString() method at the cost of some extra memory and ordering, or to store the data as a binary key by doing Buffer.from(1n.toString(16),'hex') if they are unsigned bigints, and coming up with a sign-ness encoding/decoding if they are signed.