-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add an array option type #3121
base: dev
Are you sure you want to change the base?
Conversation
also fixes some bugs lol
src/components/PluginSettings/components/SettingArrayComponent.tsx
Outdated
Show resolved
Hide resolved
…sts' into feat/api/SettingsLists
…t/api/SettingsLists # Conflicts: # src/api/Settings.ts
I think this is ready now |
@CodiumAI-Agent /review |
PR Reviewer Guide 🔍(Review updated until commit 14fe735)Here are some key observations to aid the review process:
|
@CodiumAI-Agent /review |
Persistent review updated to latest commit 14fe735 |
…t/api/SettingsLists
Adds an array option type, this replaces the previously used strings with separators.
IDs are not very user-friendly, therefore this PR also implements a Modal which replicates the functionality of Discord's forwarding Modal to search for users/channels/guilds by text.
implements: #615 #2210
Settings sync is fully functional with these changes
Filtering for names/roles when it comes to users is difficult to implement and out of scope for this PR, it also isn't needed in any existing plugin. Therefore it will be omitted. Searching for user names remains possible through the search modal.