ShowTimeoutDetails (Timeout reasons + ShowTimeoutDuration) #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Slightly changed the code, here's the result (for automod)
Also the icon is orange when automod does timeouts |
|
Here's another example. I am seeking feedback on this now |
|
I haven't posted any updates from what I made so, here's some examples of the new popout Manual timeouts Automod timeouts I didn't mention this earlier, but the timeout icon/remaining time text is set to orange |
|
ok this wide popout looks really ugly I should fix it
|
Nuckyz
force-pushed
the
dev
branch
7 times, most recently
from
bece919 to
22a5b18
Compare
|
Please ignore that this is based on #2993 for now |
Sqaaakoi
force-pushed
the
showTimeoutDetails
branch
from
c4743eb to
275e69a
Compare
|
so much code, scary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames ShowTimeoutDuration to ShowTimeoutDetails and adds reasons for timeouts.
Opening as draft for now as I haven't looked at the UI for automod timeouts properly and documented what it looks like here