Merge pull request #105 from Venafi/fix-prevent-issue-tests

Removes parallel from tests
Venafi · Sep 12, 2022 · 6009644 · 6009644
2 parents 796a32b + 4f87d7f
commit 6009644
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 37 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,4 @@
-# v0.10.6 (September 9, 2022)
+# v0.10.6 (September 12, 2022)
 Adds bug fix for Prevent-reissue feature to work on VaaS
 
 # v0.10.5 (August 30, 2022)

diff --git a/plugin/pki/backend_test.go b/plugin/pki/backend_test.go
@@ -177,7 +177,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  regDuration := time.Duration(24) * time.Hour
  // CASE: should be the SAME - same CN and SAN
  t.Run("TPP Token enroll same certificate and prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -187,7 +186,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  })
  // CASE: should be different - same CN but 1 additional SAN
  t.Run("TPP Token second enroll certificate with extra SAN DNS and should not prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -197,7 +195,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  })
  // CASE: should be different - same CN and missing 1 SAN of 3
  t.Run("TPP Token second enroll certificate and removing one SAN DNS from list and should not prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -207,7 +204,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  })
  // CASE: should be the SAME - same CN and no SANs
  t.Run("TPP Token certificate with CN only and no SAN DNS second enroll should be prevented", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -218,7 +214,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  // CASE: should be different - same CN and SAN but just barely not sufficiently valid
  t.Run("TPP Token second enroll same certificate with TTL that is not sufficient for set valid time and should not prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -231,7 +226,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  })
  // CASE: should be the SAME - same CN and SAN and just barely sufficiently valid
  t.Run("TPP Token second enroll same certificate wit TTL with barely sufficient valid time and should prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -245,7 +239,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  })
  // CASE: should be the SAME - same CN and same 3 SANs
  t.Run("TPP Token second enroll certificate with three SAN DNS and should prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -255,7 +248,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  })
  // CASE: should be different - different CN and same 3 SANs
  t.Run("TPP Token second enroll certificate with three SAN DNS but different CN and should not prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -265,7 +257,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  })
  // CASE: should be the SAME - no CN and same 3 SANs
  t.Run("TPP Token second enroll certificate with three SAN DNS but no CN and should prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -276,7 +267,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  // Service generated CSR
  // CASE: should be the SAME - same CN and SAN
  t.Run("Service Generated CSR - TPP Token enroll same certificate and prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -290,7 +280,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  // CASE: should be different - same CN but 1 additional SAN
  t.Run("Service Generated CSR - TPP Token second enroll certificate with extra SAN DNS and should not prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -304,7 +293,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  // CASE: should be different - same CN and missing 1 SAN of 3
  t.Run("Service Generated CSR - TPP Token second enroll certificate and removing one SAN DNS from list and should not prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -318,7 +306,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  // CASE: should be the SAME - same CN and no SANs
  t.Run("Service Generated CSR - TPP Token certificate with CN only and no SAN DNS second enroll should be prevented",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -332,7 +319,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  // CASE: should be different - same CN and SAN but just barely not sufficiently valid
  t.Run("Service Generated CSR - TPP Token second enroll same certificate with TTL that is not sufficient for set valid time and should not prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -347,7 +333,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  // CASE: should be the SAME - same CN and SAN and just barely sufficiently valid
  t.Run("Service Generated CSR - TPP Token second enroll same certificate wit TTL with barely sufficient valid time and should prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -362,7 +347,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  // CASE: should be the SAME - same CN and same 3 SANs
  t.Run("Service Generated CSR - TPP Token second enroll certificate with three SAN DNS and should prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -376,7 +360,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  // CASE: should be different - different CN and same 3 SANs
  t.Run("Service Generated CSR - TPP Token second enroll certificate with three SAN DNS but different CN and should not prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -390,7 +373,6 @@ func TestTPPpreventReissuance(t *testing.T) {
  // CASE: should be the SAME - no CN and same 3 SANs
  t.Run("Service Generated CSR - TPP Token second enroll certificate with three SAN DNS but no CN and should prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -407,7 +389,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  regDuration := time.Duration(24) * time.Hour
  // CASE: should be the SAME - same CN and SAN
  t.Run("VaaS enroll same certificate and prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -417,7 +398,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  })
  // CASE: should be different - same CN but 1 additional SAN
  t.Run("VaaS second enroll certificate with extra SAN DNS and should not prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -427,7 +407,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  })
  // CASE: should be different - same CN and missing 1 SAN of 3
  t.Run("VaaS second enroll certificate and removing one SAN DNS from list and should not prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -437,7 +416,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  })
  // CASE: should be the SAME - same CN and no SANs
  t.Run("VaaS certificate with CN only and no SAN DNS second enroll should be prevented", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -447,7 +425,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  })
  t.Run("VaaS second enroll same certificate with TTL that is not sufficient for set valid time and should not prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -460,7 +437,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  })
  // CASE: should be the SAME - same CN and SAN and just barely sufficiently valid
  t.Run("VaaS second enroll same certificate wit TTL with barely sufficient valid time and should prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -470,7 +446,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  })
  // CASE: should be the SAME - same CN and same 3 SANs
  t.Run("VaaS second enroll certificate with three SAN DNS and should prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -480,7 +455,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  })
  // CASE: should be different - different CN and same 3 SANs
  t.Run("VaaS second enroll certificate with three SAN DNS but different CN and should not prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -490,7 +464,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  })
  // CASE: should be the SAME - no CN and same 3 SANs
  t.Run("VaaS second enroll certificate with three SAN DNS but no CN and should prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -501,7 +474,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  // Service generated CSR
  // CASE: should be the SAME - same CN and SAN
  t.Run("Service Generated CSR - VaaS enroll same certificate and prevent-reissue", func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -515,7 +487,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  // CASE: should be different - same CN but 1 additional SAN
  t.Run("Service Generated CSR - VaaS second enroll certificate with extra SAN DNS and should not prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -529,7 +500,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  // CASE: should be different - same CN and missing 1 SAN of 3
  t.Run("Service Generated CSR - VaaS second enroll certificate and removing one SAN DNS from list and should not prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -543,7 +513,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  // CASE: should be the SAME - same CN and no SANs
  t.Run("Service Generated CSR - VaaS certificate with CN only and no SAN DNS second enroll should be prevented",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -556,7 +525,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  })
  t.Run("Service Generated CSR - VaaS second enroll same certificate with TTL that is not sufficient for set valid time and should not prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -571,7 +539,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  // CASE: should be the SAME - same CN and SAN and just barely sufficiently valid
  t.Run("Service Generated CSR - VaaS second enroll same certificate wit TTL with barely sufficient valid time and should prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -585,7 +552,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  // CASE: should be the SAME - same CN and same 3 SANs
  t.Run("Service Generated CSR - VaaS second enroll certificate with three SAN DNS and should prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -599,7 +565,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  // CASE: should be different - different CN and same 3 SANs
  t.Run("Service Generated CSR - VaaS second enroll certificate with three SAN DNS but different CN and should not prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)
@@ -614,7 +579,6 @@ func TestVaasPreventReissuance(t *testing.T) {
  t.Skip("Currently we skip this scenario as VaaS currently doesn't support it (probable bug)")
  t.Run("Service Generated CSR - VaaS second enroll certificate with three SAN DNS but no CN and should prevent-reissue",
  func(t *testing.T) {
- t.Parallel()
  integrationTestEnv, err := newIntegrationTestEnv()
  if err != nil {
  t.Fatal(err)