Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Localization (Stringtable.xml) #419

Merged
merged 33 commits into from
Nov 8, 2017
Merged

Add: Localization (Stringtable.xml) #419

merged 33 commits into from
Nov 8, 2017

Conversation

1kuemmel1
Copy link

@1kuemmel1 1kuemmel1 commented Nov 5, 2017

  • Add: Localization (Stringtable.xml).

This pull request added:

  • a multi-language support to the mission Discussion: Multilingual support #400
  • first 2 languages are: English and German
  • make it easier to add more languages (by using the stringtable.xml)

Final test:

  • local
  • server

@Vdauphin Vdauphin added this to the 1.18 milestone Nov 5, 2017
@Vdauphin Vdauphin self-requested a review November 5, 2017 13:00
Copy link
Owner

@Vdauphin Vdauphin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, very good job here!
I just saw some little missing localization:

Also, there are some conflicts with master_daily do you need help to resolve them ?

@Vdauphin
Copy link
Owner

Vdauphin commented Nov 5, 2017

When those conflicts will be resolved, you will notice some new file (due to recent PR (#398 #386)). Those files will need also a localization (in futur, to avoid this prefer to work on master_daily because master_daily add a lot of change in H&M).

We could merge this and after take care of those new files in a different PR ?

@1kuemmel1
Copy link
Author

Sorry forget about these files.

We could merge this and after take care of those new files in a different PR ?

Yeah, After the merge, I will upgrade those files as fast as possible. And yes I use a new PR for these.

@1kuemmel1
Copy link
Author

1kuemmel1 commented Nov 5, 2017

PS: The last 4 commits are just to resolve the conflicts. 😄

@Vdauphin
Copy link
Owner

Vdauphin commented Nov 5, 2017

PS: The last 4 commits are just to resolve the conflicts. 😄

Not for github 😄

@Vdauphin
Copy link
Owner

Vdauphin commented Nov 5, 2017

You need to push vdauphin/master_daily into 1kuemmel1/add-localization. Then git will tell you there are conflicts. You need now to deal with and resolve then one by one.

@Vdauphin
Copy link
Owner

Vdauphin commented Nov 5, 2017

Sorryyy vdauphin/master_daily into 1kuemmel1/add-localization

Copy link
Owner

@Vdauphin Vdauphin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I switch my Arma to German x) . And good job, works very well!
Just a little question : is it possible to have in mission parameter a little offset of the text like it was done here ?

@1kuemmel1
Copy link
Author

1kuemmel1 commented Nov 6, 2017

Found a solution for the offset problem. Should be like before.

Last time I switch my Arma to German

🤣 😄 👍

Just an additional note: to get the full language support, the dedicated server must run in the user's language ➡️ English server + German client = mixed language
Maybee, you should notice that anywhere.

@1kuemmel1
Copy link
Author

added translations for #398 and #386

[btc_gear_object, 0, ["ACE_MainActions"], _action] call ace_interact_menu_fnc_addActionToObject;

//Arsenal
_action = ["arsenal_open", (localize "STR_BTC_HAM_ACTION_ARSENAL_OPEN"), "\A3\ui_f\data\igui\cfg\simpleTasks\letters\A_ca.paa", {['Open',true] spawn BIS_fnc_arsenal;}, {true}, {}, [], [0.4,0,0.4], 5] call ace_interact_menu_fnc_createAction;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this interaction ? See this #166

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe obsolete? Tested local and on a dedicated server, no crash or error.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but this issue come randomly after some days on a dedicate server. Also, this interaction is not use by player beacause when you are more than 2 or 3 people around the box this action is no more available due to other player. The advantage of the scroll menu is even 10 players around the box, Arsenal is still available.

So I decided to remove it because it create random crash and not use by player.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will remove this.

btc_gear_object addAction ["<t color='#ff1111'>Arsenal</t>", "['Open',true] spawn BIS_fnc_arsenal;"];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localize this no ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply forget this, sorry.

@Vdauphin Vdauphin merged commit 407903a into Vdauphin:master_daily Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants