[FIX] mass_mailing: make recipients unique by email #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moylop260 Can you review? The |
|
👍 |
moylop260
reviewed
Sep 18, 2024
This commit makes the recipients of any mass.mailing res_model unique by email. The email can be read from either the email field or the partner_id.email field, if they exist, otherwise the behavior is as usual. The partner_id case requires a further loop of deduplication because partner_id.email is not stored in sale.order and read_group does not allow fetching indirect fields. Related: https://gitlab.com/ircanada/ircodoo/-/issues/2849
maneandrea
force-pushed
the
16.0-mass_mailing-make_recipients_unique-andrea
branch
from
a40852f to
ef73cf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the recipients of any mass.mailing res_model unique by email. The email can be read from either the email field or the partner_id.email field, if they exist, otherwise the behavior is as usual.
The partner_id case requires a further loop of deduplication because partner_id.email is not stored in sale.order and read_group does not allow fetching indirect fields.
Related: https://gitlab.com/ircanada/ircodoo/-/issues/2849
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr