Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light bulb offset #632

Closed
wants to merge 1 commit into from
Closed

Conversation

Oberfuhrer
Copy link
Contributor

@Oberfuhrer Oberfuhrer commented Oct 27, 2024

Description

Media

Untitled2.mp4


Changelog

🆑

  • fix: light bulb sprite offset

* Removed offset from light bulb sprite. What kind of problem can be with light to do this offset-crutch?
@Peptide90
Copy link
Collaborator

Light bulbs are offset because they look trash on slanted walls if they're not, because the whole perspective means they look like they're on the bottom of the wall.

Yes offsets are a pain when people construct lights, so the easy solution is to make a non offset light and use that for construction. Unfortunately unless someone with C# knowledge wants to make per direction offsets or per direction bounding boxes to fix a lot of our issues. Per layer drawdepths are needed for other stuff too.

You should also consult with mappers before doing this, as it'll break all our current maps by moving the lights.

I'll close this PR for now, if you want to discuss it in discord ping me or if you want to make the non offset entity and change the construction result that would be neat and we can reopen this PR for it. Thanks

@Peptide90 Peptide90 closed this Oct 27, 2024
Peptide90 pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants