Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented config parameter to turn off generic legendary item drop #8

Open
wants to merge 3 commits into
base: releases/EpicLoot/v0.9.37-vapok
Choose a base branch
from

Conversation

FominArtmind
Copy link

Motivation: currently there is no control over generic legendary item drop. Basically, if there is only one appropriate unique not set legendary item, the chance that the legendary item drops as unique or generic one is 50/50. It's not good if someone would like to have only unique items in the game (no general legendaries at all) or possess even more granular control on legendaries drop.

Backward compatibility: doesn't effect existent users of the mod since default value for the proposed config parameter is false.

Arsenii Fomin added 2 commits February 16, 2024 14:19
@FominArtmind
Copy link
Author

Updated: fixed an issue with incorrect flags interaction. Basically, there is no sense in using "Set Item Drop Chance" if "Always Drop Unique Legendaries" set to true since in the latter case whether the item is set or not is better controlled by:

  1. presence of set/not set corresponding items in legendaries.json
  2. if multiple available items present, by their SelectionWeight parameter values ratio

@FominArtmind
Copy link
Author

Still leads to "NullReferenceException: Object reference not set to an instance of an object
Stack trace:" when GenericLegendaryInfo added to the list. Closing for now since just don't understand C# behavior here and don't know how to fix it.

@FominArtmind FominArtmind reopened this Feb 24, 2024
@FominArtmind
Copy link
Author

Reworked the code to initial variant to avoid Exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant