Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular Drive is attached to hand similar to Linear Drive #304

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Briinah
Copy link

@Briinah Briinah commented Jan 31, 2019

Circular Drive, Linear Drive and Throwable all allow a player to move an object. Only Circular Drive was not attached to the hand on a grab. This change allows you to use the features of the Interactable script, as "Hide hand on attach" for the Circular Drive too.

The outAngle of Circular Drive could be updated outside of the class, as it was a public variable. The variable is now private and a property was added to allow you to still change the outAngle, but now it also updates the gameObject.

This is my first pull request, so I hope I did this right!

@xVinicius
Copy link

Please, this must be merged into master. I have to come back to this pull request every time I create a project or update the plugin 🤒

PS: It will make a year anniversary soon 🎈

@Giantbean
Copy link

Giantbean commented Feb 20, 2020

Breaking in SteamVR Unity Plugin - v2.5 (sdk 1.8.19)

Assets\SteamVR\InteractionSystem\Core\Scripts\CircularDrive.cs(275,65): error CS0103: The name 'attachmentFlags' does not exist in the current context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants