steam_helper: clean up OpenVR before getting OpenXR extensions in initialize_vr_data
#8126
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itialize_vr_data` When using OpenComposite, both OpenVR and OpenXR functions may call the same underlying OpenXR loader. Because the OpenXR loader only supports a single active instance, `initialize_vr_data` currently fails as an OpenXR instance has already been initialized ath the time XR extensions are queried. This commit fixes the problem by cleaning up the temporary OpenVR context *before* initializing OpenXR instead of keeping it open until the end of the call. Fix for: ValveSoftware#7905
|
I'm sorry for the long delay, but I finally found some time to try out your suggestion. It works as expected AFAICT, thank you for the guidance. Regarding your comment about real names: I have no intention to use my real, full name on this account and I also don't want to pretend that I do :) If your offer to pull this under your name still stands, you have my permission to do so. That goes for anyone who would be willing to do so. |
|
@eburema were you able to compile proton yet? On my machine, the docker/podman build worked fine as long as my git repo and build dir were fresh. The problems I had were always caused by:
|
Plagman
pushed a commit
that referenced
this pull request
Oct 3, 2024
…itialize_vr_data` Patch written by Emily <[email protected]> #8126 When using OpenComposite, both OpenVR and OpenXR functions may call the same underlying OpenXR loader. Because the OpenXR loader only supports a single active instance, `initialize_vr_data` currently fails as an OpenXR instance has already been initialized ath the time XR extensions are queried. This commit fixes the problem by cleaning up the temporary OpenVR context *before* initializing OpenXR instead of keeping it open until the end of the call. Fix for: #7905 Signed-off-by: Paul Gofman <[email protected]>
|
Thanks! I pushed the patch, it is in Experimental [bleeding-edge] now: 5b26b6a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using OpenComposite, both OpenVR and OpenXR functions may call the same underlying OpenXR loader.
Because the OpenXR loader only supports a single active instance,
initialize_vr_datacurrently fails as an OpenXR instance has already been initialized at the time XR extensions are queried.This commit fixes the problem by cleaning up the temporary OpenVR context before initializing OpenXR instead of keeping it open until the end of the call.
Fix for:
#7905
This is a follow-up to #7906.
As @gofman suggested, it is much simpler and safer to just close the OpenVR instance early than what I did before.
Tested with: