Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge player emu #69

Closed
wants to merge 2 commits into from
Closed

Merge player emu #69

wants to merge 2 commits into from

Conversation

jprjr
Copy link
Contributor

@jprjr jprjr commented Feb 26, 2021

Hi, this is an alternative to #68 - since it's not possible to use vgm-player without vgm-emu, it may make sense to just include vgm-emu in archives and dlls of vgm-player. The benefit of this approach is existing builds should continue to work, or worst-case, they just need to remove vgm-emu from their library lists, if they're using vgm-player.

This also fixes the issue I mentioned of simultaneously linking against libgme (as long as this is built with symbolic linking flags).

@ValleyBell
Copy link
Owner

Due to how I intend to have stuff linked (link vgm-player when using anything from the player, link vgm-emu when you explicitly use anything from emu), I prefer going with the approach from #68.

I consider linking both, vgm-emu and vgm-player perfectly valid and intentional, so this PR is a no-go for me.

@ValleyBell ValleyBell closed this Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants