Notifications for duels #189
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
February 11, 2021 22:29
added 11 commits
February 28, 2021 11:33
Comment on lines
+6
to
+7
| self.importScripts("https://www.gstatic.com/firebasejs/8.2.9/firebase-app.js"); | ||
| self.importScripts("https://www.gstatic.com/firebasejs/8.2.9/firebase-messaging.js"); |
There was a problem hiding this comment.
Is this possible to have these file in our bundle instead of downloading them from a third-party server?
| @@ -65,16 +80,64 @@ self.addEventListener("fetch", (e) => { | |||
| const newResource = r.clone(); | |||
| caches.open(cacheName).then((cache) => { | |||
| console.info(`[Service Worker] Caching new resource: ${e.request.url}`); | |||
| cache.put(e.request, newResource); | |||
| cache.put(e.request, newResource).catch(() => console.error("Can't cache new resource")); | |||
There was a problem hiding this comment.
Is this an error or a simple warning?
client/src/utils/messaging.js
Outdated
| class MessagingHandler { | ||
| constructor() { | ||
| // Information available in the firebase console | ||
| this.app = firebase.initializeApp({ |
There was a problem hiding this comment.
There was a problem hiding this comment.
Good question, I will try
added 2 commits
March 1, 2021 10:21
|
Would it be possible to change |
|
@FrancoisPog Yes, I am currently doing it on the best merge of my life :) |
added 6 commits
March 9, 2021 17:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
How it works
usertable through/api/v1/messaging/token/addIssue
The server can send notifications and the service-worker can receive them. On the other hand we encounter a bug when installing and activating firebase on the client.
Screenshots
Request for authorization for notifications:
Notification (here on macOS ❤️ ) when the app is in the background:
Notification when the app is in the foreground:
