build: Poetry v2を使う #920
Merged
build: Poetry v2を使う #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
force-pushed
the
build-use-poetry-v2
branch
from
a77b8e6 to
1962b45
Compare
Hiroshiba
approved these changes
Jan 8, 2025
| @@ -225,7 +225,9 @@ jobs: | |||
| - name: set cargo version | |||
| run: | | |||
| cargo set-version "$VERSION" --exclude voicevox_core_python_api --exclude downloader --exclude xtask | |||
| if ${{ matrix.python_whl }}; then cargo set-version "$VERSION" -p voicevox_core_python_api; fi | |||
| if ${{ matrix.python_whl }}; then | |||
| sed -i_ 's/version = "\(0\.0\.0\)"/version = "'"$VERSION"'"/' ./crates/voicevox_core_python_api/pyproject.toml | |||
There was a problem hiding this comment.
（ただのコメントです）
sedって置き換え対象の文字列がなかったとしてもエラーにならないんですよねー。。。
例えば今回の場合はversion = "\(0\.0\.0\)"のとこが別の値に変わってバージョンが入らなくなっていてもビルド時にきづけない。
あとsedはmacOSだとBSD版？が入ってて扱いづらいという。
一応s/置換前の文字列/置換後の文字列/; t; q1;などとすれば、書き換え対象の文字列がなかった場合exit 1してくれるっぽみです。
あるいはビルド時にバージョンが一致しているかどうかを確かめてもいいかも？
まあ、参考になれば。。。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
CIが壊れているのを直すついでに、Poetryをv2に上げる。
See-also: https://python-poetry.org/blog/announcing-poetry-2.0.0/
関連 Issue
その他