Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Rust APIだけTextAnalyzerをパブリックにする #919

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Jan 5, 2025

内容

Rust APIのFullcontextExtractorの役割をTextAnalyzerに譲る。基本的にそれだけ。パブリックAPIの機能としては整えない。

C, Python, Java APIにも以下の破壊的変更がもたらされる。

BREAKING-CHANGE: ExtractFullContextLabelErrorAnalyzeTextError

関連 Issue

Refs: #730

その他

#907 同様、航空機内で実装しました。インターネット抜きでできることがあまり無く…

@qryxip qryxip requested a review from Hiroshiba January 5, 2025 04:26
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

若干よくわかってないですが・・・!!
ソング導入時にどこをどうしていくかでまた考えることになる・・・かも?
(まあでも、そもそもソングはどういうアーキテクチャにするかだいぶ頭を悩ませそう)

crates/voicevox_core/src/text_analyzer.rs Outdated Show resolved Hide resolved
@qryxip qryxip merged commit c6f60b8 into VOICEVOX:main Jan 17, 2025
31 checks passed
@qryxip qryxip deleted the refactor-make-text-analyzer-pub branch January 17, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants