Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: fix up #802: C APIのrpath設定を削除 #898

Merged
merged 1 commit into from
Dec 20, 2024
Merged

feat!: fix up #802: C APIのrpath設定を削除 #898

merged 1 commit into from
Dec 20, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Dec 19, 2024 •
edited
Loading

内容

#802 により不要となった、 #203 と #251 の設定を削除する。

関連 Issue

その他

Cc: @nekomimimi

@qryxip qryxip marked this pull request as draft December 19, 2024 21:48
@qryxip
Copy link
Member Author

qryxip commented Dec 19, 2024

https://github.com/qryxip/voicevox_core/actions/runs/12421342930

@qryxip qryxip marked this pull request as ready for review December 19, 2024 22:13
@qryxip qryxip requested a review from Hiroshiba December 19, 2024 22:13
Hiroshiba
Hiroshiba approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

こうやってPR分けるのレビューしやすくてありがたいです！

@qryxip qryxip changed the title feat!: fix up #802: C APIのbuild.rsを削除 feat!: fix up #802: C APIのrpath設定を削除 Dec 20, 2024
@qryxip qryxip merged commit bf7448d into VOICEVOX:main Dec 20, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qryxip @Hiroshiba