Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps)!: bump ort #876

Merged
merged 1 commit into from
Nov 26, 2024
Merged

chore(deps)!: bump ort #876

merged 1 commit into from
Nov 26, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Nov 24, 2024

内容

関連 Issue

Resolves #859.

Refs: VOICEVOX/ort#8, VOICEVOX/ort#9, VOICEVOX/ort#10

その他

@qryxip qryxip marked this pull request as ready for review November 25, 2024 14:49
@qryxip
Copy link
Member Author

qryxip commented Nov 25, 2024

これがたまに起きるの、多分profile=defaultでnightly入れてるからか。後でPRしようかと。
https://github.com/VOICEVOX/voicevox_core/actions/runs/12012569523/job/33484073047?pr=876

@qryxip
Copy link
Member Author

qryxip commented Nov 25, 2024

↑よく考えたらこのPRも壊れたCIを直すものなので、一旦マージの方がよいかも。翌日mainブランチ上でrerunしたら多分通りますし。 @Hiroshiba

@qryxip
Copy link
Member Author

qryxip commented Nov 25, 2024

いやrust-cacheが効いてる間はCIは通るか。やっぱrustdoc直すのが先ですね。

[追記] いや待て。workflow file弄ったらrust-cache切れないか...?

@qryxip
Copy link
Member Author

qryxip commented Nov 25, 2024

いやprofileは関係無いか。nightly-2024-11-24自体が存在していない。11-2311-25はある。docs.rsはどうやって動いてるんだ…?
image
というか今日はmacos-12が…

というわけで多分明日まで待つしかない。ということでレビューだけお願いできればなーと。 @Hiroshiba

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

変更ありがとうございました!!

@qryxip qryxip merged commit 4fbca30 into VOICEVOX:main Nov 26, 2024
34 checks passed
@qryxip qryxip deleted the chore-bump-ort branch November 26, 2024 13:52
qryxip added a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is failing (rust-unit-test)
2 participants