Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Java APIのPC用ビルドを追加 #764

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Add: Java APIのPC用ビルドを追加 #764

wants to merge 22 commits into from

Conversation

sevenc-nanashi
Copy link
Member

@sevenc-nanashi sevenc-nanashi commented Mar 25, 2024 •
edited
Loading

内容

タイトル通りです。
download-artifactがv4になってpattern指定できるようになったのでリファクタついでに。

関連 Issue

（なし）

その他

サンプル：https://github.com/sevenc-nanashi/voicevox_core/actions/runs/8419271673

Hiroshiba
Hiroshiba reviewed Mar 30, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちょっとちゃんとわかってないですがほぼLGTMかなと！！

.github/workflows/build_and_deploy.yml Outdated Show resolved Hide resolved
.github/workflows/build_and_deploy.yml Outdated Show resolved Hide resolved
.github/workflows/build_and_deploy.yml Outdated Show resolved Hide resolved
crates/voicevox_core_java_api/lib/build.gradle Outdated Show resolved Hide resolved
.github/workflows/build_and_deploy.yml Show resolved Hide resolved
qryxip
qryxip approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

私からは特にありません。LGTM!

Hiroshiba
Hiroshiba reviewed Apr 14, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです！！

とやかく言っちゃってすみません！
良いコードになっていると感じました！！

@qryxip qryxip requested a review from Hiroshiba May 11, 2024 08:33
qryxip
qryxip reviewed Oct 1, 2024
View reviewed changes
.github/workflows/build_and_deploy.yml Outdated Show resolved Hide resolved
.github/workflows/build_and_deploy.yml Outdated Show resolved Hide resolved
@sevenc-nanashi
Copy link
Member Author

追従をするので一旦Draft...

@sevenc-nanashi sevenc-nanashi marked this pull request as draft October 4, 2024 13:51
@qryxip qryxip mentioned this pull request Oct 21, 2024
Merged
qryxip added a commit that referenced this pull request Oct 23, 2024
@qryxip
feat(java)!: com.microsoft.onnxruntime/onnxruntime{,_gpu}を削除 (#860)
23c2a62 
#802 により不要になったJavaの`onnxruntime{,_gpu}`パッケージを削除する。

またそれに伴い、`artifactId`をEPごとにリネームするのをやめる。

Refs: #802, #764, #858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qryxip qryxip qryxip approved these changes

@Hiroshiba Hiroshiba Awaiting requested review from Hiroshiba

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sevenc-nanashi @Hiroshiba @qryxip