-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh actionsで追加およびmanylinuxでビルドできるように変更 #693
Open
tuna2134
wants to merge
33
commits into
VOICEVOX:main
Choose a base branch
from
tuna2134:patch-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+181
−19
Open
Changes from 32 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
e3a6a01
Create CI.yml
88d3565
Merge branch 'VOICEVOX:main' into patch-1
tuna2134 c3ffca8
Merge branch 'VOICEVOX:main' into patch-1
tuna2134 5f8635d
Merge pull request #3 from tuna2134/patch-1
tuna2134 670fa97
Update CI.yml
tuna2134 73b949d
Update CI.yml
tuna2134 f1998ac
勝利宣言
tuna2134 6c3042a
Update CI.yml
tuna2134 ee0180f
Update CI.yml
tuna2134 f632406
Update CI.yml
tuna2134 0e4482d
Merge pull request #4 from tuna2134/main
tuna2134 b9dc52d
Update CI.yml
tuna2134 eb1baf8
Merge branch 'VOICEVOX:main' into patch-1
tuna2134 0c5bf40
Update CI.yml
tuna2134 c02ec70
Merge branch 'VOICEVOX:main' into main
tuna2134 c4adad1
Update CI.yml
tuna2134 e09ed7a
Update CI.yml
tuna2134 f03081b
Merge pull request #5 from tuna2134/main
tuna2134 8eb71d9
Update pyproject.toml
tuna2134 4d37b05
Update CI.yml
tuna2134 1b33050
Update CI.yml
tuna2134 9e4bd97
Remove abi3
tuna2134 db0a738
Remove sdist
tuna2134 d62c18e
Update Cargo.toml
tuna2134 889664d
manylinuxwo
tuna2134 76f54d5
pathcelf有効にしてみた
tuna2134 66db699
Merge pull request #6 from tuna2134/patchelf
tuna2134 e3fd017
Merge branch 'VOICEVOX:main' into patch-2
tuna2134 f483ab1
Merge pull request #7 from tuna2134/main
tuna2134 5475bdc
Merge branch 'VOICEVOX:main' into patch-2
tuna2134 4d03757
fix: linuxの時のみビルド
tuna2134 a3a342b
Merge pull request #8 from tuna2134/patch-1
tuna2134 c6c7a51
Merge branch 'VOICEVOX:main' into patch-2
tuna2134 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,142 @@ | ||
# This file is autogenerated by maturin v1.3.1 | ||
# To update, run | ||
# | ||
# maturin generate-ci github | ||
# | ||
name: CI | ||
|
||
on: | ||
workflow_dispatch: | ||
inputs: | ||
version: | ||
description: "バージョン情報(A.BB.C / A.BB.C-preview.D)" | ||
required: true | ||
release: | ||
types: | ||
- published | ||
|
||
env: | ||
VERSION: ${{ github.event.release.tag_name || inputs.version || '0.0.0' }} | ||
|
||
permissions: | ||
contents: read | ||
|
||
jobs: | ||
version: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Install cargo-binstall | ||
uses: taiki-e/install-action@cargo-binstall | ||
- name: Install cargo-edit | ||
run: cargo binstall cargo-edit@^0.11 --no-confirm --log-level debug | ||
- name: set cargo version | ||
run: | | ||
cargo set-version "$VERSION" --exclude voicevox_core_python_api --exclude downloader --exclude xtask | ||
- name: Upload artifacts | ||
uses: actions/upload-artifact@v3 | ||
with: | ||
name: projects | ||
path: ./ | ||
|
||
linux: | ||
runs-on: ubuntu-latest | ||
needs: version | ||
strategy: | ||
matrix: | ||
target: [x86_64, aarch64] | ||
steps: | ||
- uses: actions/download-artifact@v3 | ||
with: | ||
name: projects | ||
- uses: actions/setup-python@v4 | ||
with: | ||
python-version: '3.10' | ||
- name: Build wheels | ||
uses: PyO3/maturin-action@v1 | ||
with: | ||
target: ${{ matrix.target }} | ||
args: --release --out dist --locked --manifest-path crates/voicevox_core_python_api/Cargo.toml --find-interpreter | ||
sccache: 'true' | ||
manylinux: auto | ||
- name: Upload wheels | ||
uses: actions/upload-artifact@v3 | ||
with: | ||
name: wheels | ||
path: dist | ||
|
||
windows: | ||
runs-on: windows-latest | ||
needs: version | ||
strategy: | ||
matrix: | ||
target: [x64, x86] | ||
steps: | ||
- uses: actions/download-artifact@v3 | ||
with: | ||
name: projects | ||
- uses: actions/setup-python@v4 | ||
with: | ||
python-version: '3.10' | ||
architecture: ${{ matrix.target }} | ||
- name: Build wheels | ||
uses: PyO3/maturin-action@v1 | ||
with: | ||
target: ${{ matrix.target }} | ||
args: --release --out dist --locked --manifest-path crates/voicevox_core_python_api/Cargo.toml --find-interpreter | ||
sccache: 'true' | ||
- name: Upload wheels | ||
uses: actions/upload-artifact@v3 | ||
with: | ||
name: wheels | ||
path: dist | ||
|
||
macos: | ||
runs-on: macos-latest | ||
needs: version | ||
strategy: | ||
matrix: | ||
target: [x86_64] | ||
steps: | ||
- uses: actions/download-artifact@v3 | ||
with: | ||
name: projects | ||
- uses: actions/setup-python@v4 | ||
with: | ||
python-version: '3.10' | ||
- uses: dtolnay/rust-toolchain@stable | ||
- run: | | ||
pip install --upgrade poetry | ||
poetry config virtualenvs.create false | ||
(cd crates/voicevox_core_python_api && poetry install --with dev) | ||
- name: Build wheels | ||
uses: PyO3/maturin-action@v1 | ||
with: | ||
target: ${{ matrix.target }} | ||
args: --release --out dist --locked --manifest-path crates/voicevox_core_python_api/Cargo.toml --find-interpreter | ||
sccache: 'true' | ||
- name: Upload wheels | ||
uses: actions/upload-artifact@v3 | ||
with: | ||
name: wheels | ||
path: dist | ||
|
||
release: | ||
name: Release | ||
runs-on: ubuntu-latest | ||
if: "startsWith(github.ref, 'refs/tags/')" | ||
needs: [linux, windows, macos] | ||
permissions: | ||
id-token: write | ||
steps: | ||
- uses: actions/download-artifact@v3 | ||
with: | ||
name: wheels | ||
path: dist/ | ||
- name: Publish to PyPI | ||
uses: PyO3/maturin-action@v1 | ||
with: | ||
command: upload | ||
args: --non-interactive --skip-existing dist/* | ||
env: | ||
MATURIN_REPOSITORY_URL: https://test.pypi.org/legacy/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ライブラリをビルドするコードは
build_and_deploy.yml
に固まっているのですが、こちらに移すことは可能そうでしょうか・・・? 👀おそらくほぼ同じコードをビルドしているので、コード量やビルド時間をぐっと減らせそうなのですが、どうでしょうか・・・?
ビルドしているのはこのあたりです↓
voicevox_core/.github/workflows/build_and_deploy.yml
Lines 272 to 290 in 4e13bca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
別のことで忙しくて返信が遅れてしまいました!
できそうかと思われます。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
お久しぶりです!こちらも別タスクが忙しかったので大丈夫です!
もしよければ完成まで進められると嬉しいです!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
今からまとめてみようと思います、、、!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます、お待ちしてます・・・!