Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "hotfix: リリースがコケるのをなおす #2323

Merged

Conversation

Hiroshiba
Copy link
Member

内容

で出してマージしたPRですが、再施行すると問題なく通ったのと、修正方法がちょっと強引だったと思うので、一旦revertするのが良さそうに思いました。
一旦落ち着いてから治すので良さそうかなと。

その他

まあでもまあまあテストはコケてそうでした。

@Hiroshiba Hiroshiba requested a review from a team as a code owner October 26, 2024 11:51
@Hiroshiba
Copy link
Member Author

Hiroshiba commented Oct 26, 2024

revertの判断で良い気がするので、マージします!
問題は問題なので直したい気持ちはあります。
なにかよいGithub Actionsがあれば嬉しそう。

@Hiroshiba Hiroshiba merged commit b3f6ce9 into VOICEVOX:release-0.21 Oct 26, 2024
8 checks passed
@Hiroshiba Hiroshiba deleted the revert-hotfix-fail-release branch October 26, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant