vuexのstoreの呼び出しをリテラル引数からDot記法へ: command.ts, preset.ts, engine.ts, project.ts, audio.ts #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Segu-g
commented
Jul 27, 2024
Comment on lines
-121
to
+130
| await this.dispatch("INSTANTIATE_ENGINE_CONNECTOR", { | ||
| engineId, | ||
| }).then(async (instance) => [ | ||
| engineId, | ||
| await instance.invoke("engineManifestEngineManifestGet")({}), | ||
| ]), | ||
| await actions | ||
| .INSTANTIATE_ENGINE_CONNECTOR({ | ||
| engineId, | ||
| }) | ||
| .then(async (instance) => [ | ||
| engineId, | ||
| await instance.invoke("engineManifestEngineManifestGet")( | ||
| {}, | ||
| ), | ||
| ]), |
There was a problem hiding this comment.
何故かdispatchではなくthis.dispatchを使っていましたが、元PRでの言及もない上に変えても問題無いようなので修正しています。
Hiroshiba
approved these changes
Jul 27, 2024
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
の続きです。
store内における関数の呼び出しにおいて、dispatch("ACTION1", payloads) のような引数におけるリテラル指定から actions.ACTION(payload) のようにdot記法によるアクセスに変更します。
を変更しています。
storeの残りのsinging.tsはコンフリクトが多そうなので色々終わってからにしようと思います。
関連 Issue
スクリーンショット・動画など
その他
dispatch
actions
actions([\s\n]"([A-Z_])",?
actions.$1(
commit
mutations
mutations([\s\n]"([A-Z_])",?
mutations.$1(
の順に置換してその後眼力チェックしています。