Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ソングのデフォルトスタイルは一旦実装しない方針 #2077

Merged
merged 1 commit into from
May 21, 2024
Merged

refactor: ソングのデフォルトスタイルは一旦実装しない方針 #2077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/Dialog/AllDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ const isCharacterOrderDialogOpenComputed = computed({
}),
});

// TODO: デフォルトスタイル選択(ソング)の実装
// デフォルトスタイル選択(トーク)
const orderedTalkCharacterInfos = computed(() => {
return filterCharacterInfosByStyleType(
Expand Down
1 change: 0 additions & 1 deletion src/components/Sing/CharacterMenuButton/MenuButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,6 @@ const getDefaultStyle = (speakerUuid: string) => {

// ここで取得されるcharacterInfoには、ソングエディタ向けのスタイルのみ含まれるので、
// その中の最初のスタイルをソングエディタにおける仮のデフォルトスタイルとする
// TODO: ソングエディタ向けのデフォルトスタイルをどうするか考える
const defaultStyleId = characterInfo?.metas.styles[0].styleId;

const defaultStyle = characterInfo?.metas.styles.find(
Expand Down
3 changes: 0 additions & 3 deletions src/store/singing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,11 +230,8 @@ export const singingStore = createPartialStore<SingingStoreTypes>({

const engineId = singer?.engineId ?? state.engineIds[0];

// 最初のスタイルをソングエディタにおける仮のデフォルトスタイルとする
// TODO: ソングエディタ向けのデフォルトスタイルをどうするか考える
const defaultStyleId =
userOrderedCharacterInfos[0].metas.styles[0].styleId;

const styleId = singer?.styleId ?? defaultStyleId;

dispatch("SETUP_SINGER", { singer: { engineId, styleId } });
Expand Down
Loading