Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: ビルドログを公開鍵暗号で暗号化する #58

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Dec 25, 2024

内容

voicevox_onnxruntimeのビルドログをDiscordに流すとなるとDiscordサーバーの用意が必要なため、暗号化したログをartifactとして出してしまう。

関連 Issue

スクリーンショット・動画など

その他

@qryxip qryxip requested a review from Hiroshiba December 25, 2024 18:19
build-log-pk.asc Outdated Show resolved Hide resolved
@qryxip
Copy link
Member Author

qryxip commented Dec 25, 2024

tools/download-build-log.bashみたいなのを用意しようと思いましたが、なんかrerunしたactionだとartifactの区別が付かなくなるようで断念…

https://github.com/VOICEVOX/onnxruntime-builder/actions/runs/12490500642
https://api.github.com/repos/VOICEVOX/onnxruntime-builder/actions/runs/12490500642/artifacts

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

.github/workflows/build.yml Outdated Show resolved Hide resolved
@qryxip qryxip merged commit 08d4140 into VOICEVOX:main Dec 28, 2024
2 checks passed
@qryxip qryxip deleted the feat-gpg-e-build-log branch December 28, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants