chore: ${{ env.環境変数 }} → $環境変数
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Bashスクリプト中の
${{ env.環境変数 }}を$環境変数にするリファクタを行います。理由としては、
${{ env.環境変数 }}で書いたとしても特に静的解析が効くわけではなく、むしろShellCheckの邪魔になるからです。actionlint下では$環境変数の方がよいと思いました。関連 Issue
スクリーンショット・動画など
その他
https://github.com/qryxip/onnxruntime-builder/actions/runs/10630507299/job/29469582836