iOSのApp Storeへの申請を通るようにした #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Jan 6, 2024
There was a problem hiding this comment.
LGTM！！！
コードも整理されていてとても良いなと感じました！！
一部不要なスペースとかがありそうなので、ちょっとこちらで整形させていただきます！
@PickledChair さん
もしよければお手すきの際にレビューいただけるととても心強いです 🙇
Hiroshiba
reviewed
Jan 8, 2024
Hiroshiba
reviewed
Jan 9, 2024
xcframework/Frameworks/aarch64/onnxruntime.framework/Info.plist
Outdated
Show resolved
Hide resolved
|
voicevox_core側で、同プルリクマージ後にreleaseが作成されましたら、その後にcore側と合わせてiOS版を動作確認します！ |
Hiroshiba
reviewed
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
iOS版のvoicevox_coreのApp Storeへの申請が通らなかったため、
現状、xcframeworkの中に直接、動的ライブラリが入っていたが、
xcframeworkの中にframeworkを作り、その中に動的ライブラリを入れた。
関連 Issue
VOICEVOX/voicevox_core#715
スクリーンショット・動画など
その他
voicevox_core側の修正とセットです。
VOICEVOX/voicevox_core#723