Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS向けXCFrameworkを追加する #19

Merged
merged 12 commits into from
May 19, 2023
Merged

iOS向けXCFrameworkを追加する #19

merged 12 commits into from
May 19, 2023

Conversation

HyodaKazuaki
Copy link
Contributor

内容

iOS向けのXCFrameworkをビルドするGitHub Actionsを追加します。

このPRでは次の要素を追加しました。

  1. 各ターゲット向けdylibのUpload(build-onnxruntime job上)
  2. シミュレータ向けdylibのFat binary化(build_xcframework job上)
  3. XCFrameworkの作成(build_xcframework job上)

関連 Issue

close #18
VOICEVOX/voicevox_core#477
VOICEVOX/voicevox_core#485

PickledChair
PickledChair reviewed May 13, 2023
View reviewed changes
Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ありがとうございます！　いくつかメモやコメントをしましたのでご確認ください。

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
@HyodaKazuaki HyodaKazuaki mentioned this pull request May 13, 2023
Merged
@HyodaKazuaki
fix upload condition
d3ab74d 
for onnxruntime-rs build
PickledChair
PickledChair approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

Hiroshiba
Hiroshiba approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

結構見回しましたが、問題は発見できませんでした！！

@Hiroshiba
Copy link
Member

Hiroshiba commented May 19, 2023 •
edited
Loading

マージ後に1.14.1をリビルドしてみます！
https://github.com/VOICEVOX/onnxruntime-builder/actions/runs/5027113144

2023/05/20 20:09追記
ちょっといったんrelease-0.14を消してみます。

@Hiroshiba Hiroshiba merged commit 55f5d89 into VOICEVOX:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

@PickledChair PickledChair PickledChair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS向けXCFrameworkを追加する
3 participants
@HyodaKazuaki @Hiroshiba @PickledChair