forked from Simple-Station/Einstein-Engines
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Foreigner Traits (Simple-Station#525)
# Description Adds two negative traits, foreigner and its light version. Both of them make you unable to speak galactic common and give you a translator that lets you speak/understand GC, and also requires you to know one of the non-GC languages your entity normally speaks in order to work. The translator starts with a high-capacity power cell to compensate for the usual scarcity of publicly accessible chargers on most stations. The light version of the trait only makes you unable to speak GC. The heavy version also makes you unable to understand others when they speak it. This PR also makes you able to wear translator in the neck slot for convenience and transparency, and rewamps the examination menu of translators to provide more useful info. One little known issue (as seen in the screenshots below) is that, since the system chooses the first language in the list of languages your entity can speak, it can sometimes pick wrong if your species speaks more than two language, but it won't prevent you from using the translator normally. Also, the name of the light version of the trait is subject to change. I just couldn't think of anything more creative for it. # Why Although supposedly trystan or others have a language menu in mind, it's still not even being worked on yet. At the same time, I've already seen some people roleplay as though their characters do not speak galactic common. <details><summary><h1>Media</h1></summary> <p> ![image](https://github.com/Simple-Station/Einstein-Engines/assets/69920617/42984284-3a70-40bb-ad48-b11218cd5c5b) ![image](https://github.com/Simple-Station/Einstein-Engines/assets/69920617/f3d26cef-a908-49e7-84e0-cb50d5d98c0d) ![image](https://github.com/Simple-Station/Einstein-Engines/assets/69920617/6f44b3cc-5906-402b-ae5c-a3f0ad743bc6) ![image](https://github.com/Simple-Station/Einstein-Engines/assets/69920617/4edfe7ce-1633-4e6a-94ca-5db0dff88eb0) ![image](https://github.com/Simple-Station/Einstein-Engines/assets/69920617/ec5b3da0-b400-41f3-90c1-e5dc6b5af7c5) </p> </details> --- # Changelog :cl: - add: Added two new foreigner traits that make your character unable to speak Galactic Common and give you a translator instead. - tweak: Translators can now be equipped in the neck slot and display useful info when examined.
- Loading branch information
1 parent
e6779b6
commit 6084740
Showing
9 changed files
with
212 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
using Content.Shared.Language; | ||
using Content.Shared.Language.Systems; | ||
using Robust.Shared.Prototypes; | ||
|
||
namespace Content.Server.Traits.Assorted; | ||
|
||
/// <summary> | ||
/// When applied to a not-yet-spawned player entity, removes <see cref="BaseLanguage"/> from the lists of their languages | ||
/// and gives them a translator instead. | ||
/// </summary> | ||
[RegisterComponent] | ||
public sealed partial class ForeignerTraitComponent : Component | ||
{ | ||
/// <summary> | ||
/// The "base" language that is to be removed and substituted with a translator. | ||
/// By default, equals to the fallback language, which is GalacticCommon. | ||
/// </summary> | ||
[DataField] | ||
public ProtoId<LanguagePrototype> BaseLanguage = SharedLanguageSystem.FallbackLanguagePrototype; | ||
|
||
/// <summary> | ||
/// Whether this trait prevents the entity from understanding the base language. | ||
/// </summary> | ||
public bool CantUnderstand = true; | ||
|
||
/// <summary> | ||
/// Whether this trait prevents the entity from speaking the base language. | ||
/// </summary> | ||
public bool CantSpeak = true; | ||
|
||
/// <summary> | ||
/// The base translator prototype to use when creating a translator for the entity. | ||
/// </summary> | ||
[DataField(required: true)] | ||
public ProtoId<EntityPrototype> BaseTranslator = default!; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,105 @@ | ||
using System.Linq; | ||
using Content.Server.Hands.Systems; | ||
using Content.Server.Language; | ||
using Content.Server.Storage.EntitySystems; | ||
using Content.Shared.Clothing.Components; | ||
using Content.Shared.Inventory; | ||
using Content.Shared.Language; | ||
using Content.Shared.Language.Components; | ||
using Content.Shared.Language.Components.Translators; | ||
using Content.Shared.Storage; | ||
using Robust.Shared.Prototypes; | ||
|
||
namespace Content.Server.Traits.Assorted; | ||
|
||
|
||
public sealed partial class ForeignerTraitSystem : EntitySystem | ||
{ | ||
[Dependency] private readonly EntityManager _entMan = default!; | ||
[Dependency] private readonly HandsSystem _hands = default!; | ||
[Dependency] private readonly InventorySystem _inventory = default!; | ||
[Dependency] private readonly LanguageSystem _languages = default!; | ||
[Dependency] private readonly StorageSystem _storage = default!; | ||
|
||
public override void Initialize() | ||
{ | ||
SubscribeLocalEvent<ForeignerTraitComponent, ComponentInit>(OnSpawn); // TraitSystem adds it after PlayerSpawnCompleteEvent so it's fine | ||
} | ||
|
||
private void OnSpawn(Entity<ForeignerTraitComponent> entity, ref ComponentInit args) | ||
{ | ||
if (entity.Comp.CantUnderstand && !entity.Comp.CantSpeak) | ||
Log.Warning($"Allowing entity {entity.Owner} to speak a language but not understand it leads to undefined behavior."); | ||
|
||
if (!TryComp<LanguageKnowledgeComponent>(entity, out var knowledge)) | ||
{ | ||
Log.Warning($"Entity {entity.Owner} does not have a LanguageKnowledge but has a ForeignerTrait!"); | ||
return; | ||
} | ||
|
||
var alternateLanguage = knowledge.SpokenLanguages.Find(it => it != entity.Comp.BaseLanguage); | ||
if (alternateLanguage == null) | ||
{ | ||
Log.Warning($"Entity {entity.Owner} does not have an alternative language to choose from (must have at least one non-GC for ForeignerTrait)!"); | ||
return; | ||
} | ||
|
||
if (TryGiveTranslator(entity.Owner, entity.Comp.BaseTranslator, entity.Comp.BaseLanguage, alternateLanguage, out var translator)) | ||
{ | ||
_languages.RemoveLanguage(entity, entity.Comp.BaseLanguage, entity.Comp.CantSpeak, entity.Comp.CantUnderstand, knowledge); | ||
} | ||
} | ||
|
||
/// <summary> | ||
/// Tries to create and give the entity a translator to translator that translates speech between the two specified languages. | ||
/// </summary> | ||
public bool TryGiveTranslator( | ||
EntityUid uid, | ||
string baseTranslatorPrototype, | ||
ProtoId<LanguagePrototype> translatorLanguage, | ||
ProtoId<LanguagePrototype> entityLanguage, | ||
out EntityUid result) | ||
{ | ||
result = EntityUid.Invalid; | ||
if (translatorLanguage == entityLanguage) | ||
return false; | ||
|
||
var translator = _entMan.SpawnNextToOrDrop(baseTranslatorPrototype, uid); | ||
result = translator; | ||
|
||
if (!TryComp<HandheldTranslatorComponent>(translator, out var handheld)) | ||
{ | ||
handheld = AddComp<HandheldTranslatorComponent>(translator); | ||
handheld.ToggleOnInteract = true; | ||
handheld.SetLanguageOnInteract = true; | ||
} | ||
|
||
// Allows to speak the specified language and requires entities language. | ||
handheld.SpokenLanguages = [translatorLanguage]; | ||
handheld.UnderstoodLanguages = [translatorLanguage]; | ||
handheld.RequiredLanguages = [entityLanguage]; | ||
|
||
// Try to put it in entities hand | ||
if (_hands.TryPickupAnyHand(uid, translator, false, false, false)) | ||
return true; | ||
|
||
// Try to find a valid clothing slot on the entity and equip the translator there | ||
if (TryComp<ClothingComponent>(translator, out var clothing) | ||
&& clothing.Slots != SlotFlags.NONE | ||
&& _inventory.TryGetSlots(uid, out var slots) | ||
&& slots.Any(it => _inventory.TryEquip(uid, translator, it.Name, true, false))) | ||
return true; | ||
|
||
// Try to put the translator into entities bag, if it has one | ||
if (_inventory.TryGetSlotEntity(uid, "back", out var bag) | ||
&& TryComp<StorageComponent>(bag, out var storage) | ||
&& _storage.Insert(bag.Value, translator, out _, null, storage, false, false)) | ||
return true; | ||
|
||
// If all of the above has failed, just drop it at the same location as the entity | ||
// This should ideally never happen, but who knows. | ||
Transform(translator).Coordinates = Transform(uid).Coordinates; | ||
|
||
return true; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,13 @@ | ||
translator-component-shutoff = The {$translator} shuts off. | ||
translator-component-turnon = The {$translator} turns on. | ||
translator-enabled = It appears to be active. | ||
translator-disabled = It appears to be disabled. | ||
translator-implanter-refuse = The {$implanter} has no effect on {$target}. | ||
translator-implanter-success = The {$implanter} successfully injected {$target}. | ||
translator-implanter-ready = This implanter appears to be ready to use. | ||
translator-implanter-used = This implanter seems empty. | ||
translator-examined-langs-understood = It can translate from: [color=green]{$languages}[/color]. | ||
translator-examined-langs-spoken = It can translate to: [color=green]{$languages}[/color]. | ||
translator-examined-requires-any = It requires you to know at least one of these languages: [color=yellow]{$languages}[/color]. | ||
translator-examined-requires-all = It requires you to know all of these languages: [color=yellow]{$languages}[/color]. | ||
translator-examined-enabled = It appears to be [color=green]active[/color]. | ||
translator-examined-disabled = It appears to be [color=red]turned off[/color]. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters