-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create publish workflow #17
Conversation
Note for future ref: discussion on #16. @danjohnson95 @ianlandsman what's left on this? I'd love to get the notifier actually running on my macbook 😉 |
I'd also love to get this running on my MacBook, but we can't publish in a CI environment until NativePHP/electron#74 (comment) is approved and merged 😞 |
@danjohnson95 good news! It's merged now 😄 |
Excellent! I've bumped the composer file to point to the specific commit because it hasn't been tagged yet. This should be everything required to build in CI for macOS, upload to GitHub Releases, and automatically roll out the update to existing users. Once this is merged in, I'll keep an eye on the pipeline to see if it works as intended and I may need to raise a separate PR to fix any potential issues. |
@ianlandsman looks like something you need to fix: https://github.com/UserScape/larajobs-desktop/actions/runs/7352162872/job/20016515689#step:8:167 |
Sorry for the delay, not totally clear what that error is but there was an agreement to agree to in the apple dev console so I did that. |
@danjohnson95 any idea what's going wrong in the logs here: https://github.com/UserScape/larajobs-desktop/actions/runs/7352162872/job/20671888416#step:8:135? |
Work in progress - I'll let you know when this is good for review