Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create publish workflow #17

Merged
merged 29 commits into from
Dec 28, 2023
Merged

Conversation

danjohnson95
Copy link
Contributor

@danjohnson95 danjohnson95 commented Aug 14, 2023

Work in progress - I'll let you know when this is good for review

@danjohnson95 danjohnson95 marked this pull request as draft August 14, 2023 19:54
@LukeTowers
Copy link
Collaborator

Note for future ref: discussion on #16.

@danjohnson95 @ianlandsman what's left on this? I'd love to get the notifier actually running on my macbook 😉

@danjohnson95
Copy link
Contributor Author

I'd also love to get this running on my MacBook, but we can't publish in a CI environment until NativePHP/electron#74 (comment) is approved and merged 😞

@LukeTowers
Copy link
Collaborator

@danjohnson95 good news! It's merged now 😄

@danjohnson95 danjohnson95 marked this pull request as ready for review December 28, 2023 15:47
@danjohnson95
Copy link
Contributor Author

Excellent! I've bumped the composer file to point to the specific commit because it hasn't been tagged yet.

This should be everything required to build in CI for macOS, upload to GitHub Releases, and automatically roll out the update to existing users.

Once this is merged in, I'll keep an eye on the pipeline to see if it works as intended and I may need to raise a separate PR to fix any potential issues.

@LukeTowers LukeTowers merged commit df5afe4 into UserScape:main Dec 28, 2023
2 checks passed
@LukeTowers
Copy link
Collaborator

@ianlandsman
Copy link
Member

Sorry for the delay, not totally clear what that error is but there was an agreement to agree to in the apple dev console so I did that.

@LukeTowers
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants