Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved download page #41

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Improved download page #41

wants to merge 7 commits into from

Conversation

msemple1111
Copy link

Improved the download page like it is suggested here

index.html Outdated
font-size: 30px;
}

.linebrBefore:before {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this class? Could this be solved using padding or margin instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should have been solved that way. I have corrected it to use margin instead now.

@andre-d
Copy link
Contributor

andre-d commented Dec 22, 2015

Aside from the code style and code problems, the UI is a bit confusing. Re-using the upload dialog is confusing as previously that sort of UI is a drop zone for files and now it is a download button so it seems weird as a pure button. But aside from that small confusion the UI itself looks bad because the large box is not centered vertically and its hard for the eye to find a space. It would be better with a smaller download button and if you really want a box putting a border around the whole thing.

@msemple1111
Copy link
Author

I updated the UI according to your suggestions @andre-d. I'm not particularly good at UI design so welcome any suggestions!
I have fixed the code problems you mentioned @k3d3. I think that is it but if you find a few more, i'll gladly fix them too.

@Upload Upload deleted a comment from yuu0007 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants