F/vl 547 captions firefox

[JamesUoM]

Allow caption selection in Firefox. This reverts a change that was made to aid accessibility as part of PAEL-8

To aid testing captions added to test pages

[ppettit]

tested on latest chrome, firefox and safari and seems to work fine 👍

[ppettit]

I took another peek at this and I think there is a bug stopping the popup from being closed in the PopupContainer base class:

paella/src/05_plugin_base.js

Lines 355 to 368 in 6a30bb6

	$(button).keypress(function(event) {
	if ( (event.keyCode == 13) && (!this.plugin.isPopUpOpen()) ){
	if (this.plugin.isPopUpOpen()) {
	paella.player.controls.playbackControl().hidePopUp(this.popUpIdentifier,this,true);
	}
	else {
	paella.player.controls.playbackControl().showPopUp(this.popUpIdentifier,this,true);
	}
	}
	else if ( (event.keyCode == 27)){
	paella.player.controls.playbackControl().hidePopUp(this.popUpIdentifier,this,true);
	}
	event.preventDefault();
	});

It definitely seems like a bug as it makes the hidePopup on line 357 unreachable. The following change on line 356 fixes it:

-                        if ( (event.keyCode == 13) && (!this.plugin.isPopUpOpen()) ){
+                        if (event.keyCode == 13)  {

The code does also check for ESC key, but (at least for me on linux/firefox) ESC events never get to this bit of code for some reason.