Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove matplotlib constraint #3505

Merged
merged 3 commits into from
Aug 9, 2024
Merged

chore: remove matplotlib constraint #3505

merged 3 commits into from
Aug 9, 2024

Conversation

Coniferish
Copy link
Collaborator

No description provided.

@Coniferish Coniferish changed the title remove matplotlib constraint chore: remove matplotlib constraint Aug 9, 2024
# Note(yuming) - pining to avoid conflict with paddle install
matplotlib==3.7.2
# TODO: Pinned in transformers package, remove when that gets updated
tokenizers>=0.19,<0.20
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed matplotlib constraint and replaced with upstream tokenizers constraint

Copy link
Contributor

@MthwRobinson MthwRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests are passing

@Coniferish Coniferish marked this pull request as ready for review August 9, 2024 19:28
@Coniferish Coniferish enabled auto-merge August 9, 2024 19:28
@Coniferish Coniferish added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit a2ae2ed Aug 9, 2024
51 checks passed
@Coniferish Coniferish deleted the jj/matplotlib2 branch August 9, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants