Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump botocore pin #3493

Merged
merged 3 commits into from
Aug 7, 2024
Merged

chore: bump botocore pin #3493

merged 3 commits into from
Aug 7, 2024

Conversation

Coniferish
Copy link
Collaborator

@Coniferish Coniferish commented Aug 7, 2024

bump botocore pin to match aiobotocore/s pin:
aio-libs/aiobotocore@eae9743

@@ -46,7 +46,7 @@ packaging<24.0
urllib3<1.27

# TODO: Constriant due to aiobotocore, remove when that gets updates:
botocore<1.34.52
botocore<1.34.132
Copy link
Collaborator Author

@Coniferish Coniferish Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped to match aiobotocore bump

Copy link
Collaborator

@scanny scanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I pretty much rely on the tests passing as the criteria on these. Maybe let Matt have a look though.

@MthwRobinson
Copy link
Contributor

Yeah for these as long as tests are passing after the bump, we're good to go.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 7, 2024
@Coniferish Coniferish added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 43ae0be Aug 7, 2024
51 checks passed
@Coniferish Coniferish deleted the jj/botocore branch August 7, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants