chore: update importlib-metadata pin #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coniferish
commented
Aug 7, 2024
| @@ -1,6 +1,10 @@ | |||
| -c ../deps/constraints.txt | |||
| -c ../base.txt | |||
| chromadb | |||
| importlib-metadata>=7.1.0 | |||
| importlib-metadata>=8.2.0 | |||
There was a problem hiding this comment.
Added this pin.
opentelemetry-api has importlib-metadata pinned here to "importlib-metadata >= 6.0, <= 8.2.0",
There was a problem hiding this comment.
Other extras were resolving to 8.2.0, but chroma was resolving to 8.0.0 for some reason. Pinned 8.2.0 as a minimum version to force the chroma dependency to match the others.
Coniferish
commented
Aug 7, 2024
|
|
||
| # NOTE(robinson): choma was pinned to importlib-metadata>=7.1.0 but 7.1.0 was installed | ||
| # instead of 7.2.0. Need to investigate | ||
| importlib-metadata==7.1.0 |
There was a problem hiding this comment.
Removed this pin
Coniferish
force-pushed
the
jj/importlib
branch
from
7d25195 to
8c2348a
Compare
MthwRobinson
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.