chore: remove cryptography pin and update test #3482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Coniferish
force-pushed
the
jj/cryptography
branch
from
41aba52 to
93e5eb8
Compare
Coniferish
force-pushed
the
jj/cryptography
branch
from
93e5eb8 to
66c4d27
Compare
Coniferish
commented
Aug 6, 2024
| # tenacity 9.0.0 is being installed via chroma, but other dependencies (langchain) restrict tenacity | ||
| # to <=9.0.0 in other depenceny extras and resolve to 8.5.0. | ||
| # The original langchain pin: https://github.com/langchain-ai/langchain/pull/849/ | ||
| tenacity==8.5.0 |
There was a problem hiding this comment.
explanation for pin in case Langchain updates their pin and we can remove this
scanny
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove cryptography pin, pin tenacity, and update test_unstructured_ingest/unit/connector/test_salesforce_connector.py