chore: small edits #3480
Merged
chore: small edits #3480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scanny
requested changes
Aug 5, 2024
scanny
reviewed
Aug 5, 2024
| @@ -102,7 +102,7 @@ def test_partition_via_api_raises_with_bad_response(request: FixtureRequest): | |||
| partition_mock_.assert_called_once() | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(skip_outside_ci, reason="Skipping test run outside of CI") | |||
| @pytest.mark.skipif(not is_in_ci, reason="Skipping test run outside of CI") | |||
There was a problem hiding this comment.
Are the rest of these skipped for the same reason?
There was a problem hiding this comment.
I don't know. I didn't look into it
scanny
approved these changes
Aug 6, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
Add comments and fix decorators on some tests.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comments and fix decorators on some tests.