feat: save file id for all fsspec connectors if present #3405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbiseck3
force-pushed
the
roman/add-file-id-to-box
branch
from
97c2452 to
57165df
Compare
|
I looked into adding this to S3 since it is based on fsspec but has it's own |
rbiseck3
force-pushed
the
roman/add-file-id-to-box
branch
from
57165df to
52ac2a9
Compare
…t fixtures update (#3419) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: rbiseck3 <[email protected]>
rbiseck3
force-pushed
the
roman/add-file-id-to-box
branch
from
340166c to
83fada8
Compare
rbiseck3
added
the
ingest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the id value exists in the stats response from fsspec, save it as a
file_idfield in the metadata being persisted on each element.