Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move jest test to vitest #130

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Conversation

yuming-long
Copy link
Contributor

Summary

as suggested by speakeasy:

Also noticed that your installation of Jest in the SDK repo is causing an npm audit warning with 1 high severity vulnerability. If you're keen to switch then I highly recommend vitest. It's a mostly drop-in alternative and requires no config to work. We use it to test our SDKs.

Also found that its easy to add coverage report just by appending --coverage add the end of the make test commands, but tbd in the future

Test

ci should work as before

Copy link
Collaborator

@Coniferish Coniferish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yuming-long yuming-long merged commit d50004b into main Oct 21, 2024
2 checks passed
@yuming-long yuming-long deleted the yuming/move_jest_test_to_vitest branch October 21, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants