Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate localization files to JSON format #748

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patel-nikhil
Copy link
Collaborator

@patel-nikhil patel-nikhil commented Jan 19, 2021

Changes the localization files to use JSON format. Also, identifiers are now lower case in the definition with case-insensitive access from the code.

@Krarilotus Krarilotus added Probably not before next release Version wait with this until after next release source code anything that has to do with the code of the UCP labels Feb 23, 2021
@Krarilotus Krarilotus removed the Probably not before next release Version wait with this until after next release label Aug 6, 2021
@patel-nikhil patel-nikhil marked this pull request as draft September 12, 2021 14:16
@patel-nikhil
Copy link
Collaborator Author

Noticed a couple bugs, not ready for review yet

@gynt
Copy link
Collaborator

gynt commented Dec 3, 2021

What is the status of this nice project? :)

@patel-nikhil
Copy link
Collaborator Author

The change was almost entirely accomplished using a script. Current translations used custom? or at least special logic for certain formatting - example being an & at the end of a line meant a new line and if I recall the current supports multiline translations which were parsed to have \n instead.

I came across two or three translations that were missing in the GUI when testing, that’s when I moved PR back to draft. Basically what’s needed is some manual auditing of the translations.

@patel-nikhil
Copy link
Collaborator Author

What’s our take on having translations for individual ‘changes’ stored with the change itself as configuration/resource? And generally moving away from having a single big file with all the translations.

@patel-nikhil
Copy link
Collaborator Author

It’d also be a lot easier to review if the translations aren’t all in a single file

@gynt
Copy link
Collaborator

gynt commented Dec 4, 2021

What’s our take on having translations for individual ‘changes’ stored with the change itself as configuration/resource? And generally moving away from having a single big file with all the translations.

Since features move into its own modules, the translation should move there as well. Since we ship certain features I don't mind where the translations end up, but a big file could be prevented indeed.

I want to merge this PR for the time being though, and/or copy the JSON files into the UCP module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source code anything that has to do with the code of the UCP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants