-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate localization files to JSON format #748
base: master
Are you sure you want to change the base?
Migrate localization files to JSON format #748
Conversation
1fc0ad0
to
f62d195
Compare
Noticed a couple bugs, not ready for review yet |
What is the status of this nice project? :) |
The change was almost entirely accomplished using a script. Current translations used custom? or at least special logic for certain formatting - example being an & at the end of a line meant a new line and if I recall the current supports multiline translations which were parsed to have \n instead. I came across two or three translations that were missing in the GUI when testing, that’s when I moved PR back to draft. Basically what’s needed is some manual auditing of the translations. |
What’s our take on having translations for individual ‘changes’ stored with the change itself as configuration/resource? And generally moving away from having a single big file with all the translations. |
It’d also be a lot easier to review if the translations aren’t all in a single file |
Since features move into its own modules, the translation should move there as well. Since we ship certain features I don't mind where the translations end up, but a big file could be prevented indeed. I want to merge this PR for the time being though, and/or copy the JSON files into the UCP module. |
Changes the localization files to use JSON format. Also, identifiers are now lower case in the definition with case-insensitive access from the code.